fix completions replacing punctuation#2618
Closed
xdBronch wants to merge 1 commit intozigtools:masterfrom
Closed
Conversation
Member
|
This does not handle "replace" text edits correctly in certain cases: const foo = 5;
const bar = foo(f<cursor>oo);The "replace" text edit should change the line to the following: const bar = foo(foo);but instead it does the same as the "insert" text edit: const bar = foo(foooo);Test Case: try testCompletionTextEdit(.{
.source =
\\const foo = 5;
\\const bar = foo(<cursor>foo);
,
.label = "foo",
.expected_insert_line = "const bar = foo(foofoo);",
.expected_replace_line = "const bar = foo(foo);",
});Since I had some related fixes to completion text edits, I went ahead and fixed this in #2621. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
basically the same as #2605, the
(,[,{would get replaced when completions were manually triggeredthis affected a lot more than what I added tests for but it seems unlikely that any one in particular would uniquely regress so I just did some more likely cases to keep it small